[flashrom-gerrit] [M] Change in flashrom[master]: tests: Convert selfcheck to unit tests

[Evan Benn (Code Review)]

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.

Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69620 )

Change subject: tests: Convert selfcheck to unit tests
......................................................................

Patch Set 6:

(2 comments)

File tests/well_formed_tables.c:

https://review.coreboot.org/c/flashrom/+/69620/comment/990d77b2_55fd41a0 
PS5, Line 54: flashchips[i].name
> `chip->name` ?

Done

https://review.coreboot.org/c/flashrom/+/69620/comment/a7acc1b4_388c672a 
PS5, Line 73: 		if ((b->first_vendor == 0 || b->first_device == 0 || b->second_vendor == 0
            : 		     || b->second_device == 0)
            : 		    || ((b->lb_vendor == NULL) ^ (b->lb_part == NULL))
            : 		    || (b->max_rom_decode_parallel == 0 && b->enable == NULL))
> This rather large predicate could be tighten up by canonicalisation of the two patterns `x == 0` and […]

Done