Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36420 )
Change subject: sb600spi.c: Consolidate smbus dev reversion derivation ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/flashrom/+/36420/3/sb600spi.c File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/36420/3/sb600spi.c@103 PS3, Line 103: if (rev < 0) : return; That's the result from the u8 returned by pci_read_byte. When is this supposed to trigger?