Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim.
Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83140?usp=email )
Change subject: flashchips: add GD25LB256E chip model
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
This looks good, thank you! I have just one comment about commit message.
Commit Message:
https://review.coreboot.org/c/flashrom/+/83140/comment/86ed56f1_7cbf7c9e?usp... :
PS1, Line 12:
Could you please add here, in commit message, the operations that you tested? We usually add this information in commit message when adding a chip model.
Just list what you tested, for example:
Tested read, write, erase, --wp-enable, --wp-disable, --wp-list and --wp-range
(but list what you were testing).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83140?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0aa520b068a86098f6b4a1b68401c425b33e501f
Gerrit-Change-Number: 83140
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Lim
vlim@gigadevice.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Victor Lim
vlim@gigadevice.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Fri, 21 Jun 2024 08:06:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No