Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41646 )
Change subject: tests/: Add flashrom.c unit tests
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/41646/2/tests/flashrom.c
File tests/flashrom.c:
PS2:
But then, if we change the strings we print, we'll have to update this test as well?
Yes.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/41646
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d9213f98c6c9639f2417466ba4895117e8d600a
Gerrit-Change-Number: 41646
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 22 May 2020 14:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment