Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47661 )
Change subject: it87spi.c: Reorder functions with primitives at the top
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/47661/1/it87spi.c
File it87spi.c:
https://review.coreboot.org/c/flashrom/+/47661/1/it87spi.c@36
PS1, Line 36: /* Helper functions for most recent ITE IT87xx Super I/O chips */
You're splitting this comment from the functions it's attached to (with some #defines specific to those functions in between).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I94b169d19cb29336bb9cb4c16d0efee15b1e14c2
Gerrit-Change-Number: 47661
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 19 Nov 2020 04:50:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment