David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43602 )
Change subject: git-hooks: Import check-style from coreboot ......................................................................
Patch Set 2:
(5 comments)
I tried simplifying this so that the check-style script is run directly from the pre-commit hook (i.e. no Makefile or Meson changes needed) and we can also omit the cruft you pointed out.
This patch now just imports check-style from coreboot, the follow-up makes flashrom-specific changes.
https://review.coreboot.org/c/flashrom/+/43602/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/43602/1//COMMIT_MSG@11 PS1, Line 11: Add check-style rule to Makefile
I'm not sure I understand... The pre-commit hook doesn't care about the build system. […]
Removed Makefile rule in favor of calling check-style directly from pre-commit hook.
https://review.coreboot.org/c/flashrom/+/43602/1//COMMIT_MSG@14 PS1, Line 14: - Import checkpatch.pl, along with certain dependencies (spelling.txt : and const_structs.checkpatch) and .checkpatch.conf.
I am not so keen, -2 not so keen, on having coreboot's unreasonbly slow pre-commit hook stuff land […]
Removed checkpatch and spelling-related stuff.
https://review.coreboot.org/c/flashrom/+/43602/1//COMMIT_MSG@16 PS1, Line 16: Add .clang-format from CB:3
I am in favour of clang-format coming to Flashrom and it has been suggested a number of times now. […]
Moved to CB:44095
https://review.coreboot.org/c/flashrom/+/43602/1/util/git-hooks/pre-commit File util/git-hooks/pre-commit:
https://review.coreboot.org/c/flashrom/+/43602/1/util/git-hooks/pre-commit@2... PS1, Line 28: sleep 5
We can reduce or remove this if desired.
Removed.
https://review.coreboot.org/c/flashrom/+/43602/1/util/lint/const_structs.che... File util/lint/const_structs.checkpatch:
https://review.coreboot.org/c/flashrom/+/43602/1/util/lint/const_structs.che... PS1, Line 1: cpi_dock_ops : address_space_operations : backlight_ops : block_device_operations : dentry_operations : dev_pm_ops : dma_map_ops : extent_io_ops : file_lock_operations : file_operations : hv_ops : ide_dma_ops : intel_dvo_dev_ops : item_operations : iwl_ops : kgdb_arch : kgdb_io : kset_uevent_ops : lock_manager_operations : microcode_ops : mtrr_ops : neigh_ops : nlmsvc_binding : of_device_id : pci_raw_ops : pipe_buf_operations : platform_hibernation_ops : platform_suspend_ops : proto_ops : rpc_pipe_ops : seq_operations : snd_ac97_build_ops : soc_pcmcia_socket_ops : stacktrace_ops : sysfs_ops : tty_operations : uart_ops : usb_mon_operations : wd_ops
none of these have anything to do with flashrom
Done