Attention is currently required from: Alan Green, Nico Huber, Samir Ibradžić. Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Implement spi_send_multicommand() ......................................................................
Patch Set 28:
(5 comments)
Patchset:
PS28: Thank you very much for the comments! I´ll do the left changes next time I get some more idle time.
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/40477/comment/76c687d3_9a814477 PS25, Line 278: struct spi_command *cmds)
This is very oddly indented. Tabs and spaces but still not aligned […]
Done
https://review.coreboot.org/c/flashrom/+/40477/comment/f01839fa_9fefe416 PS25, Line 283: int i = 0,ret = 0, failed = 0;
missing space after first comma.
Done
https://review.coreboot.org/c/flashrom/+/40477/comment/d05ec628_5ae95ca2 PS25, Line 304: 0 & ~pinlvl;
The respective expression in ft2232_spi_send_command() got a fix in […]
Done
https://review.coreboot.org/c/flashrom/+/40477/comment/d317a6e5_218938c1 PS25, Line 326: optionally
Either […]
Done