9 May
2023
9 May
'23
2:13 p.m.
Attention is currently required from: Chen, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75011 )
Change subject: spi: add cs=tms option to jlink_spi programmer ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1: Chen, thank you for the patch! It's a nice and clean change, looks good!
I have a question about testing: you probably tested this on hardware? Can you add testing info in commit message? Thanks!
--
To view, visit https://review.coreboot.org/c/flashrom/+/75011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1
Gerrit-Change-Number: 75011
Gerrit-PatchSet: 1
Gerrit-Owner: Chen c@jia.je
Gerrit-Reviewer: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Chen c@jia.je
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Tue, 09 May 2023 12:13:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment