Attention is currently required from: Ao Zhong, Martin L Roth.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63596?usp=email )
Change subject: flashchips.c: Add voltage data to chips without that ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4: Thank you so much for doing these voltage patches!
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/63596/comment/2dadd040_2ff9a008 : PS4, Line 17628: .voltage = {4500, 5500} Removing voltage, is this intentional?
https://review.coreboot.org/c/flashrom/+/63596/comment/2b51f80d_0601e637 : PS4, Line 8452: .voltage = {2700, 3600}, Maybe it's safer to add voltage data at once, and correct values? (vs adding in one patch and immediately changing in the next one).
I am thinking, maybe remove these lines from previous patch, and add here. So that both patches only add lines. What do you think?