Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35611 )
Change subject: cli_classic.c: Tidy up some repeated handling patterns into funcs ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/35611/3/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35611/3/cli_classic.c@a430 PS3, Line 430: if ((read_it | write_it | verify_it) && check_filename(filename, "image")) { : cli_classic_abort_usage(); : } : if (layoutfile && check_filename(layoutfile, "layout")) { : cli_classic_abort_usage(); : } : if (fmapfile && check_filename(fmapfile, "fmap")) { : cli_classic_abort_usage(); : } : if (referencefile && check_filename(referencefile, "reference")) { : cli_classic_abort_usage(); : } are we removing this more "defensive" coding style on purpose?