Attention is currently required from: Nico Huber, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55353 )
Change subject: flashchips: Add support for MACRONIX MX66L1G45G ......................................................................
Patch Set 1: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55353/comment/d8aa1e69_343f41ff PS1, Line 7: MACRONIX nit: `Macronix`
Patchset:
PS1: I didn't look at a datasheet yet
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/55353/comment/9ed5cee8_a5f432fa PS1, Line 10075: }, nit: flashchip entries are separated by a blank line
https://review.coreboot.org/c/flashrom/+/55353/comment/8cb89df5_ec24e1d0 PS1, Line 10078: MACRONIX_ Drop this prefix?
https://review.coreboot.org/c/flashrom/+/55353/comment/3c8c1355_ac42d184 PS1, Line 10117: MX25L12835F Hmmmmm... Smells like copy-pasta?
https://review.coreboot.org/c/flashrom/+/55353/comment/0af9b43a_cc6a5983 PS1, Line 10123: }, same here, flashchip entries are separated by a blank line