Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61198 )
Change subject: meson: build hwaccess only on x86
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/61198/comment/7841498b_db90defa
PS1, Line 9: Throw an error if an user tries to build a programmer which requires
: hwaccess on nox-x86 platforms.
Suggestion:
hwaccess is only available for x86 platforms. Thus, guard the source
files and throw an error on non-x86 platforms if flashrom should be
built with a programmer requiring it.
File meson.build:
https://review.coreboot.org/c/flashrom/+/61198/comment/12d9fdfb_50a8f345
PS1, Line 357: need
need_s_
--
To view, visit
https://review.coreboot.org/c/flashrom/+/61198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iafabe8b4b2a95697773a739501dfc62d880d3f6d
Gerrit-Change-Number: 61198
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Wed, 19 Jan 2022 12:26:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
