Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen.
Riku Viitanen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80498?usp=email )
Change subject: serprog: Add support for multiple SPI chip selects ......................................................................
Patch Set 3:
(2 comments)
File serprog.c:
https://review.coreboot.org/c/flashrom/+/80498/comment/3f25b3df_26921c58 : PS2, Line 827: cs = extract_programmer_param_str(cfg, "cs");
Since you are adding new programmer param, you need to update manpage as well. […]
Done
https://review.coreboot.org/c/flashrom/+/80498/comment/c8e20a51_b41dca81 : PS2, Line 833: msg_perr("Error: Invalid chip select requested! " : "Only 0-255 are valid.\n");
Not critical comment, but: this can be one line (and same for another error message before). […]
Acknowledged