14 Oct
2019
14 Oct
'19
5:22 a.m.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35295 )
Change subject: util/git-hooks: Check for Signed-off-by line ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35295/3/util/git-hooks/commit-msg File util/git-hooks/commit-msg:
https://review.coreboot.org/c/flashrom/+/35295/3/util/git-hooks/commit-msg@1... PS3, Line 198: +
Nit, this + seems spurious, what does it refer to? […]
Yeah, I can't think of a reason + is necessary in this case. If there's a good reason to remove it then we should fix it in coreboot as well.
--
To view, visit https://review.coreboot.org/c/flashrom/+/35295
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iea49a06c2d4824be073eff98c8aae1cbc5b145e4
Gerrit-Change-Number: 35295
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Stefan T stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Oct 2019 05:22:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment