18 Jul
2019
18 Jul
'19
1:06 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34403 )
Change subject: pickit2_spi: Fix "dead" assignment ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Thanks!
https://review.coreboot.org/c/flashrom/+/34403/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/34403/2//COMMIT_MSG@10 PS2, Line 10: and exit if it failed. Please separate paragraphs with an empty line (or remove the line break).
https://review.coreboot.org/c/flashrom/+/34403/2//COMMIT_MSG@13 PS2, Line 13: Found-by I guess `Found-by` should be followed by a colon.
--
To view, visit https://review.coreboot.org/c/flashrom/+/34403
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4aac5e1f3bd0604b079e1fdd9b7f09f1f4fc2d7f
Gerrit-Change-Number: 34403
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 18 Jul 2019 13:06:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment