Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67004 )
Change subject: Use chipsize_t (uint32_t) for all range types
......................................................................
Patch Set 3:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/67004/comment/d5cb7453_8aabb6bd
PS3, Line 852: const chipsize_t region_start = entry->start;
I removed chipoff_t during this migration, as I did not understand the use case for having two types […]
I should say I dont mind adding it back or keeping chipoff_t instead of chipsize_t, but I would want to understand what the purpose is before doing it.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I31348806b7ea92a6ea8391a735f722a63aa7e488
Gerrit-Change-Number: 67004
Gerrit-PatchSet: 3
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 07 Sep 2022 05:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evan Benn
evanbenn@google.com
Gerrit-MessageType: comment