Nico Huber has posted comments on this change. ( https://review.coreboot.org/22383 )
Change subject: spi25: Use common code for nbyte read/write and block erase
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/22383/1/spi25.c
File spi25.c:
https://review.coreboot.org/#/c/22383/1/spi25.c@384
PS1, Line 384: if
`iff` is short for `if and only if`... I can write it out ofc.
Done
--
To view, visit
https://review.coreboot.org/22383
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1ae48acbfbd427a30bcd64bdc080dc3dc20503
Gerrit-Change-Number: 22383
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 13 Nov 2017 19:16:50 +0000
Gerrit-HasComments: Yes