[flashrom-gerrit] [S] Change in flashrom[1.2.x]: dmi: Correctly check for ERROR_PTR

[Felix Singer (Code Review)]

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67875 )

Change subject: dmi: Correctly check for ERROR_PTR
......................................................................

dmi: Correctly check for ERROR_PTR

For the physmap*() functions, NULL is considered valid return value.
Fixes a segmentation fault when DMI tables can't be mapped.

Tested on intel/eblake board with broken coreboot.

Change-Id: Ic403c2940c2b91acbd113f0acfa3ce9ef6c6bb6c
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/62611
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67875
Reviewed-by: Felix Singer 
---
M dmi.c
1 file changed, 21 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Singer: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/dmi.c b/dmi.c
index c44221c..7488d61 100644
--- a/dmi.c
+++ b/dmi.c
@@ -164,7 +164,7 @@
    unsigned int i = 0, j = 0;

uint8_t *dmi_table_mem = physmap_ro("DMI Table", base, len);
-	if (dmi_table_mem == NULL) {
+	if (dmi_table_mem == ERROR_PTR) {
    	msg_perr("Unable to access DMI Table\n");
    	return;
    }