Attention is currently required from: Nico Huber, Miklós Márton, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54190 )
Change subject: stlinkv3_spi.c: Clean up properly on all init error paths
......................................................................
Patch Set 3:
(1 comment)
File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/54190/comment/65a9549c_b417bf72
PS1, Line 443: stlinkv3_command(command, sizeof(command), answer, sizeof(answer), "STLINK_BRIDGE_CLOSE");
Hello Anastasia, […]
You are welcome! :) Thanks for explanation!
As a result, now I have two init error exit paths, but because this is something I did before (see CB:52597 CB:52685 CB:52773) I keep the same names for labels to [eventually] be consistent across the tree.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54190
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9fabf48068635593bc86006c9642d8569eee8447
Gerrit-Change-Number: 54190
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 17 May 2021 05:11:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Miklós Márton
martonmiklosqdev@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment