Attention is currently required from: Felix Singer, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68230 )
Change subject: rayer_spi.c: Move param parse logic into own func
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File rayer_spi.c:
https://review.coreboot.org/c/flashrom/+/68230/comment/2ffe256c_c7f338c8
PS1, Line 292: if (prog_type) {
: for (; prog->type != NULL; prog++) {
: if (strcasecmp(prog_type, prog->type) == 0) {
: break;
: }
: }
: free(prog_type);
:
: if (prog->type == NULL) {
: msg_perr("Error: Invalid device type specified.\n");
: return 1;
: }
: }
Isn't this part of getting the params?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68230
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I287aa2e5d94e872553d08c0750f8dc6d60b9caff
Gerrit-Change-Number: 68230
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Sat, 08 Oct 2022 08:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment