28 Apr
2020
28 Apr
'20
2:13 a.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40667 )
Change subject: Initial Realtek MST i2c_spi support ......................................................................
Patch Set 4:
(1 comment)
Patch Set 2:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/flashrom/+/40667/3/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/40667/3/realtek_mst_i2c_spi.c@323 PS3, Line 323: // ret |= realtek_mst_i2c_spi_enable_write_protection(fd);
probably remove the comment?
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/40667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I892e0be776fe605e69fb39c77abf3016591d7123
Gerrit-Change-Number: 40667
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward Hill ecgh@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Shiyu Sun sshiyu@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Andrew McRae amcrae@chromium.org
Gerrit-CC: Daniel Kurtz djkurtz@google.com
Gerrit-Comment-Date: Tue, 28 Apr 2020 02:13:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shiyu Sun sshiyu@google.com
Gerrit-MessageType: comment