Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38209 )
Change subject: raiden_debug: Upstream ChromiumOS servo debug board prog ......................................................................
Patch Set 7:
(2 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/38209/comment/1639fed3_542d2235 PS7, Line 229: ifeq ($(CONFIG_RAIDEN), yes) : UNSUPPORTED_FEATURES += CONFIG_RAIDEN=yes : else : override CONFIG_RAIDEN = no : endif
What's the reasoning here? Does it need more than libusb?
No it shouldn't. I can't fully recall now however I *think* this ended up here because it was never tested on Windows or maybe I just got lost in all the ifdef's.
I have prepared a patch to drop the hunk: https://review.coreboot.org/c/flashrom/+/51930
File meson.build:
https://review.coreboot.org/c/flashrom/+/38209/comment/c7dc72c1_8cfad78b PS7, Line 109: config_raiden = false
Huh, this dependency is not mentioned in the Makefile...
this is most definitely incorrect! thanks, the line somehow founds its way from the above block, fixed in the above mentioned patch.