Attention is currently required from: Victor Ding.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44580 )
Change subject: Add ENE LPC programmer
......................................................................
Patch Set 3:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/44580/comment/328ad7a2_a994a4df
PS3, Line 177: endif
The code was ported from Chromium's flashrom fork, I don't think it has ever been verified on DOS; t […]
We do not verify every change to common code on DOS either. What makes this
code special so that it needs extra verification, I wouldn't know. But it's
good to know that there was a reason. As it was placed below the libusb
comment, it looked like an accident.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/44580
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I970afd8c1bd92c159c60e09f22e2f18c0433729d
Gerrit-Change-Number: 44580
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Ding
victording@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Victor Ding
victording@google.com
Gerrit-Comment-Date: Mon, 28 Jun 2021 07:33:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Victor Ding
victording@google.com
Gerrit-MessageType: comment
