Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45674 )
Change subject: realtek_mst_i2c_spi.c: Introduce MCU reset param ......................................................................
Patch Set 10: -Code-Review
(3 comments)
https://review.coreboot.org/c/flashrom/+/45674/10/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/45674/10/realtek_mst_i2c_spi.c@444 PS10, Line 444: if
else if
Done
https://review.coreboot.org/c/flashrom/+/45674/10/realtek_mst_i2c_spi.c@452 PS10, Line 452: /* It's fine to not set this parameter. */
Please initialize `*reset` here.
Done
https://review.coreboot.org/c/flashrom/+/45674/10/realtek_mst_i2c_spi.c@476 PS10, Line 476: if (reset) {
I see that the MPU is reset here and during programmer shutdown. […]
Hey Angel, thanks for your feedback!
Actually though we should remove the MCU reset from the init all together. This was only put here when we knew far less about the internal fw that runs on the MST. Turns out no reset is needed for correct programming and so no reset should ever be preformed pre-flash.
We only want the binary condition on never reset (by default) or reset after programming tear-down and so I removed it here in the follow up patch. I think there was some mis-communication initially with Shiyu on who is driving this part hence the series of patches that got pushed without a specific direction set in stone.