4 Oct
2019
4 Oct
'19
4:47 p.m.
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35800 )
Change subject: Fix more sign-compare issues ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/35800/2/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/35800/2/ich_descriptors.c@424 PS2, Line 424: min Would be nice to have a min() that didn't cast everything to int, but that can wait till later.
--
To view, visit https://review.coreboot.org/c/flashrom/+/35800
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If36ba22606021400b385ea6083eacc7b360c20c5
Gerrit-Change-Number: 35800
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 Oct 2019 16:47:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment