Attention is currently required from: Nico Huber.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59050 )
Change subject: Makefile: Make pkg-config mandatory to find libpci
......................................................................
Patch Set 13:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/59050/comment/6837eab4_7274980f
PS7, Line 772: # This is a dirty hack, but it saves us from checking all PCI drivers and all platforms manually.
: # libpci may need raw memory, MSR or PCI port I/O on some platforms.
: # Individual drivers might have the same needs as well.
Yes, eventually, but for now I would just keep the comment above […]
Wait for https://review.coreboot.org/c/flashrom/+/60114/6
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59050
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I21b4a261b34b7e688635fc6e20b7beebfa64c7ed
Gerrit-Change-Number: 59050
Gerrit-PatchSet: 13
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 22 Dec 2021 12:57:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment
