Attention is currently required from: Felix Singer, Nico Huber, Martin L Roth. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64499 )
Change subject: Add reviewers group to allow +1, -1 changes. ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
We can discuss that in the flashrom meeting and see if more changes are desired.
I remember you asked me on the meeting, but I got a bit confused (I wasn't entirely sure whether I understood your explanations). Sorry for that!
Yes the decision was for "flashrom reviewers" to have -1..+2 permissions, and no submit, no -2. Just -1..+2.
I suspect that permissions given by the 'all projects' group are still going to be active unless negated here.
What are the permissions given by "all projects" group? If that's -1..+1 this is fine. All Gerrit users have -1..+1.
I also have another question: when the change gets into effect, is it after the patch is submitted? Does it mean that we need to immediately populate "flashrom reviewers" with people? Because as I understand, this patch creates a group but does not populate with it people.
Another reason I am asking about when the change gets into effect, I am thinking to write an email to coreboot people who lose +2 on flashrom as a result. I have some vague ideas of what should be in the email, but roughly it should explain "what has happened", "reasons for this", "how to get +2 back".
Thank you for the patch, sorry I only noticed it today.