Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33833 )
Change subject: flashchips.c: Fix field order ......................................................................
Patch Set 8:
(2 comments)
Patch Set 6: Code-Review+1
(2 comments)
There is an inconsistency.
I'll send a separate change that tidies up the .tested field.
https://review.coreboot.org/#/c/33833/6/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/33833/6/flashchips.c@2543 PS6, Line 2543: .
Missing space?
Well spotted. This wasn't one of the inconsistencies I was targeting with this change. I'll send a separate change.
https://review.coreboot.org/#/c/33833/6/flashchips.c@3433 PS6, Line 3433:
Extra space?
I'll push this into another change.