Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38939 )
Change subject: Install the man file when using meson as a buildsystem
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/flashrom/+/38939/2/flashrom.8.tmpl
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/38939/2/flashrom.8.tmpl@43
PS2, Line 43: .TH FLASHROM 8 "@MAN_DATE@" "@VERSION@" "@MAN_DATE@"
It would be desirable. Having two build systems is a bit of a mess, IMHO.
Ack
https://review.coreboot.org/c/flashrom/+/38939/1/meson.build
File meson.build:
https://review.coreboot.org/c/flashrom/+/38939/1/meson.build@383
PS1, Line 383:
flashrom.8.tmpl is a template file and requires processing. Quoting from the Makefile: […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/38939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I881bd5002a842072ce9dadea033c51a2668f9e7c
Gerrit-Change-Number: 38939
Gerrit-PatchSet: 4
Gerrit-Owner: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006@gmx.net
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Wed, 15 Jul 2020 12:27:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006@gmx.net
Gerrit-MessageType: comment