Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Samantaz Fox has posted comments on this change by Samantaz Fox. ( https://review.coreboot.org/c/flashrom/+/83969?usp=email )
Change subject: flashchips: Add definitions for Fudan FM25Q04, FM25Q64 and FM25Q128 ......................................................................
Patch Set 2:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83969/comment/29973fc1_59d12432?usp... : PS2, Line 6228: {2700, 3600}
For Q04 and Q64, datasheet says 2.3-3.6V, is there a reason why you put 2.7-3.6 here? […]
As I wasn't really sure what to trust* and haven't done any testing to confirm that, I preferred to use the same values as the other FM25Qxx chip definitions. In addition, the comment left on line 6146 ("2.3-2.7V acceptable results in lower performance") for the "FM25F02(A)" leads me to believe that this product range might not have the spec they claim.
* [Fudan's website](https://eng.fmsh.com/442f95b6-77cd-1d42-4f8e-4ddc187481d1/) says that the whole FM25Fxx/FM25Qxx product range should run on 2.3V-3.6V, but the table on that same page contradicts itself (the FM25Q32 is listed as 2.7V-3.6V) and so does multiple datasheets, as you can see.