2 Sep
2022
2 Sep
'22
12:12 p.m.
Attention is currently required from: Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66671 )
Change subject: tree: Fix drivers to pass prog_param to pcidev_init() ......................................................................
Patch Set 7:
(1 comment)
File include/programmer.h:
https://review.coreboot.org/c/flashrom/+/66671/comment/c005f7ad_1df858ac PS3, Line 126: const char *
Is there a reason why parameter name is omitted? Other parameters have names. […]
well it is higher typed now is it ok? usually prototypes don't need identifiers in truth and they tend to go stale anyway. happy to put cfg there if there is a strong feeling
--
To view, visit https://review.coreboot.org/c/flashrom/+/66671
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie0c9d1c0866d44f64d037c596f2e30547fcfd58f
Gerrit-Change-Number: 66671
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Fri, 02 Sep 2022 12:12:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment