Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )
Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11: Sorry for bringing up that name discussion again but since I plan to add another flashrom module/plugin for ITE ecs, it might be a good idea to be sure about the names. Today I managed to get external flashing via I2C/DBGR working and I will start bringing this to flashrom next week.
ITE ecs can be flashed in various ways: - with fw interaction (this implementation) - via hardware / ec functionality - FWH (I don't think we'll ever need this) - I2EC LPC index/data registers ("Depth-2 I/O") - DBGR/EPP parallel flashing via KBC port - DBGR/SMBus via SMBus (e.g. on battery connector) <-- this is what I'll implement / port
Side note: I hacked together a test tool some months ago for reading both internal and external flash via LPC/I2EC. Since flashing via I2EC is basically the same as via DBGR (same registers, just through a different interface), so I might add that as well later.
At some point someone (I guess it was Nico, but I didn't find the comment...) proposed using "ite_ecfw" as name for this - currently it is named "ite_ec". IMHO we really should not miss the "fw" in this implementation's name to avoid confusion with other implementations (like hw), since it depends on implementation specific firmware functionality, where e.g. the commands (read, write, erase) are not hardware- but software-defined.
Names for I2C/DBGR flashing I'm going to add could then be, for example: "ite_ec_dbgr", "ite_ec_smb" - other ideas welcome.