30 Dec
2019
30 Dec
'19
3:43 p.m.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36946 )
Change subject: Fix a handful of compiler warnings ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/flashrom/+/36946/8/Makefile File Makefile:
https://review.coreboot.org/c/flashrom/+/36946/8/Makefile@40 PS8, Line 40: ifeq ($(CC),clang) In my experience this can be dropped, as there now should not be enum conversion warnings anymore. Tested on FreeBSD 13-CURRENT with gcc9 and clang 9.
--
To view, visit https://review.coreboot.org/c/flashrom/+/36946
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d01f4ff620f4c4111dd675d49ce3254f2360b29
Gerrit-Change-Number: 36946
Gerrit-PatchSet: 8
Gerrit-Owner: Ryan O'Leary ryanoleary@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Ryan O'Leary ryanoleary@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Idwer Vollering vidwer@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Dec 2019 14:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment