Samir Ibradžić has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39532 )
Change subject: flashchips: Add Macronix MX25R3235F ......................................................................
Patch Set 2:
(4 comments)
Patch Set 1: Code-Review+1
(4 comments)
Just a few comments on the commit message. I'm sorry that it took me so long to review.
Thnx!
All sorted out & "Fixed:" reference to GH issue added as suggested by Paul. Can we have it merged please?
Cheers
https://review.coreboot.org/c/flashrom/+/39532/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/39532/1//COMMIT_MSG@9 PS1, Line 9: 4MB
That would be 4 MiB, actually. […]
Done
https://review.coreboot.org/c/flashrom/+/39532/1//COMMIT_MSG@12 PS1, Line 12: Similar to already supported MX25R6435F, just half the size.
Make this a sentence, for example: […]
Done
https://review.coreboot.org/c/flashrom/+/39532/1//COMMIT_MSG@14 PS1, Line 14: 4232H
Did you mean "FT4232H" and "FT2232H" ?
Done
https://review.coreboot.org/c/flashrom/+/39532/1//COMMIT_MSG@15 PS1, Line 15: &
just "and"
Done