Attention is currently required from: Paul Menzel, Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62725 )
Change subject: libflashrom.c: Fix unintialized value passed to function ......................................................................
Patch Set 8:
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62725/comment/4cab97f9_7fb67547 PS1, Line 7: fixed
Fix
Done
https://review.coreboot.org/c/flashrom/+/62725/comment/21ff9726_77bfe34c PS1, Line 7: unintialized
typo: uninitialized
Done
https://review.coreboot.org/c/flashrom/+/62725/comment/f9753369_97f97c77 PS1, Line 9: y
t
Done
https://review.coreboot.org/c/flashrom/+/62725/comment/e8906c23_ce6faf20 PS1, Line 9: In function flash_layouy_read_from_ifd variable chip_layout remains uninitialized if prepare_flash_access returns
Please wrap commit message lines at 72 characters, c.f. https://flashrom. […]
Done
https://review.coreboot.org/c/flashrom/+/62725/comment/48451152_364a8005 PS1, Line 10: unintialzed
2 typos: uninitialized
Done
https://review.coreboot.org/c/flashrom/+/62725/comment/9388ea73_05b118da PS1, Line 10: flase
typo: false
Done
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/62725/comment/c85e277b_9ed5fec6 PS1, Line 445: struct flashrom_layout *dump_layout=0, *chip_layout=0;
Since these are pointers, I'd use NULL. […]
Done