Brian Nemec has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41533 )
Change subject: raiden_debug_spi.c: Add support for USB SPI protocol V2
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c@450
PS10, Line 450: #define PAYLOAD_SIZE_V2_START (58)
:
: #define PAYLOAD_SIZE_V2_RESPONSE (60)
:
: #define PAYLOAD_SIZE_V2_CONTINUE (60)
:
: #define PAYLOAD_SIZE_V2_ERROR (60)
This is V2, maybe put it next to the other V2 definitions?
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/41533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie356c63b521c0cc11a4946ffac128ec7139f0bec
Gerrit-Change-Number: 41533
Gerrit-PatchSet: 11
Gerrit-Owner: Brian Nemec
bnemec@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Brian Nemec
bnemec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jul 2020 17:33:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment