Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44073 )
Change subject: sb600spi.c: Add support for 0x790b rev 0x61 (AMD Zen)
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/flashrom/+/44073/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/44073/1//COMMIT_MSG@9
PS1, Line 9: Note that the
: read callback requires a memory mapping.
It doesn't work without it? Unfortunately cros just doesn't have the quality of commit message that […]
Resolved now that the paths have been appropriately split and a little more is known about the SPI100 controller.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/44073
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5ce63b5de863aed0442cb4ffeff981e9b2fa445b
Gerrit-Change-Number: 44073
Gerrit-PatchSet: 10
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Chris McDonald
cjmcdonald@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Comment-Date: Tue, 15 Dec 2020 10:02:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment