Attention is currently required from: Paul Menzel, Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62726 )
Change subject: serprog.c: Avoid calling memcpy with NULL pointer arguments ......................................................................
Patch Set 7:
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62726/comment/1f78df71_9ef1b823 PS1, Line 7: Fixed
Fix
Done
https://review.coreboot.org/c/flashrom/+/62726/comment/81142cd9_9fb8e93e PS1, Line 7: n
Remove extra `n` at the end
Done
https://review.coreboot.org/c/flashrom/+/62726/comment/4d9def4f_f9e1fde2 PS1, Line 7: Fixed passed null value when expectingn nonnull
How about: […]
Done
https://review.coreboot.org/c/flashrom/+/62726/comment/fc73a52e_273e9342 PS1, Line 11: Just added a check before : memcpy for parms==NULL.
How about: […]
Done
File serprog.c:
https://review.coreboot.org/c/flashrom/+/62726/comment/28883722_01f34ce2 PS1, Line 294: if
Please add a space after `if`
Done
https://review.coreboot.org/c/flashrom/+/62726/comment/eb10ccf1_ca6888e7 PS1, Line 295: memcpy(&(sp[1]), parms, parmlen);
We use tabs for indentation, and a tab is 8 characters wide. Please refer to https://flashrom. […]
Done