David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38208 )
Change subject: Add .clang-format to help with patch formatting
......................................................................
Patch Set 2:
Nice! I've been wanting to do this for a while since formatting issues are a common problem especially with submissions we get from newcomers (e.g. thru Github). I'll be happy to take a closer look at this later in the week.
The coding style is similar to coreboot, though we have a couple of differences for line length and tables: https://www.flashrom.org/Development_Guidelines#Coding_style
As Edward said we probably need to fix up a lot of stuff that's currently in the tree.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/38208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2306f9fa56caca2b1572f55a02c53fe10f51b7ad
Gerrit-Change-Number: 38208
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 07 Jan 2020 00:00:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment