24 Apr
2020
24 Apr
'20
3:39 a.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40667 )
Change subject: Initial Realtek MST i2c_spi support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/40667/1/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/40667/1/realtek_mst_i2c_spi.c@95 PS1, Line 95: while
missing space after while
Done, however that is the least of the problems here no point in commenting on style Angel.
That said lspcon_i2c_spi.c looks like it needs that fix as well.
--
To view, visit https://review.coreboot.org/c/flashrom/+/40667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I892e0be776fe605e69fb39c77abf3016591d7123
Gerrit-Change-Number: 40667
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Shiyu Sun sshiyu@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz djkurtz@google.com
Gerrit-Comment-Date: Fri, 24 Apr 2020 03:39:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment