Attention is currently required from: Angel Pons, Nico Huber, Nikolai Artemiev, Paul Menzel, Simon Buhrow, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40431?usp=email )
Change subject: flashchips: Add ISSI IS25LQ016
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3:
I did a manual rebase, checked the values from datasheet. Needs another pair of eyes to review and approve :)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/40431/comment/fb3b1944_e0d2f54a :
PS2, Line 7444: 1024B
Datasheet says 256B?
Done
https://review.coreboot.org/c/flashrom/+/40431/comment/c6d17b8e_f2269759 :
PS2, Line 7467: },
Missing […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/40431?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494
Gerrit-Change-Number: 40431
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Sat, 05 Aug 2023 13:17:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
