Attention is currently required from: Sam McNally, Nico Huber, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62282 )
Change subject: ichspi: Add Jasper Lake support ......................................................................
Patch Set 7:
(3 comments)
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/62282/comment/ce1eecaf_89898e10 PS6, Line 1013: jlk
Jasper lake is usually abbreviated as JSL.
Done
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62282/comment/7638cd0c_2f1fea6d PS6, Line 313: case CHIPSET_JASPER_LAKE:
From the SPI programming guide I've seen (v0.8), this should use freq_str[1].
Ah your right, in rev 0.8 2020 I did see this in section 3.2. I think the version I looked at was earlier. Fixed then. Thanks for spotting this Sam!
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62282/comment/2189d7f8_3ba3fb9f PS6, Line 2063: msg_pdbg("Enabling hardware sequencing by default for Apollo/Gemini/Elkhart Lake.\n");
Update the message to include Jasper Lake.
Done