Attention is currently required from: Anastasia Klimchuk.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68755 )
Change subject: tests: add probe lifecycle test for ch341a_spi
......................................................................
Patch Set 4:
(1 comment)
File tests/ch341a_spi.c:
https://review.coreboot.org/c/flashrom/+/68755/comment/7f44c8c4_e85392e2
PS3, Line 26: /* Since the test transfers a data that fits in one CH341 packet, we
: don't need an array of these transfers (as is done in the driver code). */
Please align with code style: https://www.flashrom.org/Development_Guidelines#Coding_style […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68755
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0a2d5591d097435fc69719e1d9bd153433425821
Gerrit-Change-Number: 68755
Gerrit-PatchSet: 4
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 23 Nov 2022 14:28:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment