Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42555 )
Change subject: [RFC] tree: Prepare for reformatting ......................................................................
Patch Set 3:
(2 comments)
I agree with some of the changes, e.g. dropping dead URLs and some other cleanups. But as it currently is, this commit would need to be split.
https://review.coreboot.org/c/flashrom/+/42555/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/42555/3//COMMIT_MSG@24 PS3, Line 24: flashchips This one file is so huge it deserves its own commit.
https://review.coreboot.org/c/flashrom/+/42555/3/nicintel_spi.c File nicintel_spi.c:
https://review.coreboot.org/c/flashrom/+/42555/3/nicintel_spi.c@71 PS3, Line 71: #if 0 Do the definitions conflict with anything? If not, maybe just uncomment them?