Attention is currently required from: Felix Singer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 )
Change subject: Introduce an `include` directory for header files
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
Patchset:
PS7:
I uploaded new patchset because flash.h has changed (SR3 support in CB:60230 and CB:60231) and gerrit marked this as conflict.
I downloaded this patch on the top of the tree locally, it got applied automatically, no conflict resolutions were needed. I also checked that flash.h in latest patchset is up-to-date (contains SR3 support).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58622
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf
Gerrit-Change-Number: 58622
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
martinroth@google.com
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Fri, 29 Apr 2022 01:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment