Attention is currently required from: Nico Huber, Angel Pons, Michael Niewöhner, Sergii Dmytruk. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 )
Change subject: acpi_ec: Implement basic ACPI embedded controller API ......................................................................
Patch Set 9:
(2 comments)
File acpi_ec.h:
https://review.coreboot.org/c/flashrom/+/55714/comment/b3d8ba73_29e7df11 PS4, Line 41: bool ec_wait_for_ibuf(uint8_t control_port, unsigned int max_checks); : bool ec_wait_for_obuf(uint8_t control_port, unsigned int max_checks);
Still there.
I am sorry, I was sure I have removed them... Done
File acpi_ec.h:
https://review.coreboot.org/c/flashrom/+/55714/comment/34445f05_99678eb0 PS1, Line 41: bool ec_wait_for_ibuf(uint8_t control_port); : bool ec_wait_for_obuf(uint8_t control_port, unsigned int max_checks);
So, I've been looking through the code of the follow ups. There is indeed […]
Unexported EC_MAX_STATUS_CHECKS and replaced all timeouts with zero where appropriate. I have been following the reference implementation where all communication with EC is secured with a timeout. This way we may avoid any unwanted hangs in the code (and there are a lot of calls in the programmer, it would be difficult to locate when something fails).