19 Oct
2022
19 Oct
'22
6:27 p.m.
Attention is currently required from: Alexander Goncharov.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66690 )
Change subject: nicintel_eeprom: refactor i210 variable into reentrant pattern ......................................................................
Patch Set 5:
(1 comment)
File nicintel_eeprom.c:
https://review.coreboot.org/c/flashrom/+/66690/comment/0d83e76a_929e4dea PS5, Line 84: done_i20_write
Hmmm, this was probably meant to be `done_i210_write` ever since it was introduced. […]
Fixed in CB:68582.
--
To view, visit https://review.coreboot.org/c/flashrom/+/66690
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifda0d8666399ea165bac6378c57720b5560806f1
Gerrit-Change-Number: 66690
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Wed, 19 Oct 2022 18:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment