Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38488 )
Change subject: Automatic programmer driver writer ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/flashrom/+/38488/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/38488/1//COMMIT_MSG@16 PS1, Line 16: for a in *; do test -f $a.mine && mv $a.mine $a; done
Then you are using git incorrectly.
I would love to use git correctly. How can I make git aware that I do not want to add the same chunk twice to a file when I rerun build_new_driver.sh ? Right now you can run the script as often as you want without having the new chunks inserted multiple times.
https://review.coreboot.org/c/flashrom/+/38488/1//COMMIT_MSG@28 PS1, Line 28: Icdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcd000001
You shouldn’t change it later to not confuse Gerrit.
Oh, the Change-Id gets changed all the time, just not explicitly. People abandon their change and submit a new one. The effect on Gerrit is identical (history is lost). I do agree that losing review history is suboptimal, though. I might skip it this time.