Attention is currently required from: Richard Hughes, David Hendricks, Mario Limonciello, Edward O'Callaghan, Daniel Campello.
Richard Hughes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51552 )
Change subject: meson: add missing meson options from ebuild
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
The wiki option is fine, but I don't think the static library option is correct. I think if you change the `shared_library()` to just `library()` then you can do `-Ddefault_library=static` and everything should magically work. I didn't know a static library was ever desired, so this is why I didn't use `library()` on initial submission. Apologies.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/51552
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97d2fd687aa21533b86f9af446038bfe3da1f7d3
Gerrit-Change-Number: 51552
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Mario Limonciello
superm1@gmail.com
Gerrit-Reviewer: Richard Hughes
hughsient@gmail.com
Gerrit-Reviewer: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Richard Hughes
richard@hughsie.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Mario Limonciello
superm1@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Comment-Date: Wed, 17 Mar 2021 10:44:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment