Joel Stanley has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34595 )
Change subject: flashchips: add W25M512JV ......................................................................
Patch Set 1:
(5 comments)
Thanks for the review. I needed to recover a system again today which reminded me to revisit this. I'll upload a v2 that I've tested works.
https://review.coreboot.org/c/flashrom/+/34595/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/34595/1//COMMIT_MSG@7 PS1, Line 7: W25M512JV
Code says W25*Q*512JV
Done
https://review.coreboot.org/c/flashrom/+/34595/1/flashchips.c File flashchips.c:
PS1:
Please keep entries in this file sorted by `.vendor` and `.name`.
Done
https://review.coreboot.org/c/flashrom/+/34595/1/flashchips.c@15910 PS1, Line 15910: 1024
Datasheet says 256 as usual?
Done
https://review.coreboot.org/c/flashrom/+/34595/1/flashchips.c@15912 PS1, Line 15912: .tested = TEST_OK_PREW,
Seems like this needs an update.
I don't understand, can you explain what you mean?
https://review.coreboot.org/c/flashrom/+/34595/1/flashchips.c@15914 PS1, Line 15914: .probe_timing = TIMING_ZERO,
You'll have to add some erase functions to `.block_erasers`. They […]
Done